How to handle OAuth correctly

Highlighted
New Member
4 0 0

Hello,

 

I followed this tutorial:

 

https://developers.shopify.com/tutorials/build-a-shopify-app-with-node-and-react

 

And this package to handle OAuth: 

 

https://github.com/Shopify/quilt/tree/master/packages/koa-shopify-auth

 

When I submitted the app for approval, I get a rejection notice saying we are not following OAuth correctly when we followed the tutorial and are using Shopify's official package. The partner team is not even telling me where the "get app" button is linking to. It should be linking to https://dashboard.openship.org/shopify/auth?store={shop_name}.myshopify.com as per the tutorial: 

 

https://developers.shopify.com/tutorials/build-a-shopify-app-with-node-and-react/embed-your-app-in-s...

 

The process works as follows:

 

1. The "get app" button links to https://dashboard.openship.org/shopify/auth?store={shop_name}.myshopify.com

2. User is redirected to {shop_name}.myshopify.com where they can approve and install the app

3. The callback url is https://dashboard.openship.org/shops?shopName={shop_name}

4. At this point, the user may have to sign-in or sign up for an account if not logged in already. Openship works with other platforms, not just Shopify.

 

What are we doing wrong? There is a very real discrepancy between the packages and tutorials Shopify has and the app approval process.

 

   

0 Likes
Shopify Staff
Shopify Staff
383 51 62

Hey @openship

 

Were you able to make progress on this? 

 

https://dashboard.openship.org/shopify/auth?store=<my-store>.myshopify.com is redirecting me to https://admin/apps/0ec759dec1f98df8321ddefe4fc35494 

0 Likes
New Member
4 0 0

Hello,

 

Ok so it seems like the "App URL" in the app settings on the partner dashboard is what the get URL links to. I changed this to the correct auth route: 

 

https://dashboard.openship.org/shopify/auth

 

But now, a new issue has come up. The application redirect fails at first like the tutorial says it can sometimes (please check screenshot attached). The app approval person said this needs to be fixed, but this is an issue with Shopify's official package and tutorial. I opened an issue on Github last week and have yet to get a response. How do we fix this and get our app approved?

 

 

Screen Shot 2019-12-17 at 1.31.16 PM.png

0 Likes
Shopify Staff
Shopify Staff
383 51 62

Hey @openship,

 

How are you initiating the redirect/where are you redirecting to?

0 Likes