Development Approach

Highlighted
New Member
15 0 0
Shopify Team, I have setup a shopify account for my wife http://babypouter.shopify.com. I think it is great you guys are using Ruby on Rails. I have done RoR work myself on www.explainpmt.com. I am also the Co-Creator of Watij, which is the java version of watir. I would like to understand more about your development approach. Are you guys unit testing? Do you currently have an automated functional regression suite? I ask because, today, the look and feel page was changed and the themes are no longer accessible. If you have an automated regression suite, how much coverage do you have? I did not know how to contact you directly, so I thought I could post on the forum. Not trying to question your abilities, just want to understand the stability of shopify. Also, as users of shopify identify potential defects, how would you prefer they report them. Thanks in advance, Jake Dempsey http://watij.xwiki.com
0 Likes
Shopify Staff
Shopify Staff
2002 0 46

Hey Kristy,

One thing first: We autoamte everything. Deployment, Changelogs, Coverage checks, unit, functional and even integration testing is done automatically.

Currently shopify has circa one line of code in test cases for every one line of code in production. The actual numbers fluctuate a bit because we keep improving our test case methods and replace many lines of test case code with single asset statemens hence shrinking the LOC.

The regression today happend because we tie to the latest SVN version of rails using a facility called svn:externals. When we deploy our code the rails source is automatically updated every time. This is because I’m also one of the rails developers and frequently fix bugs in rails directly which i need for shopify.

However today it bit us in the behind: I ran unit tests before deployment without running an update on the rails code. Everything was fine locally but deployment on our production server farm caused even newer rails code to be fetched which caused urls with points in them to be handled badly.

The only thing which we do not unit test at this point is our javascript. This is a bit of a sore point, especially since the checkout process relies heavily on it. I hope to create some test coverage for JS as well and i’m looking at getting a stand alone version of Spidermonkey, the firefox JS engine, to run those alongside the normal unit tests.

Tobias Lütke - Shopify CEO // http://twitter.com/tobi
0 Likes
Highlighted
New Member
15 0 0

Thank you for your quick response. You guys have built an awesome product and based on your comments, are also building a very tested tool. Kristy has been raving about shopify since she began working with her storefront and I have enjoyed enhancing it for her as well.

I didn’t see that you responded to the question about defects found by account holders. Do you intend on setting up a channel for collecting defects from the accoutn holders, or would you rather a post to the forum of someone’s findings?

Jake

0 Likes
Highlighted
Shopify Staff
Shopify Staff
2002 0 46

Ah right, There is a feedback link at the bottom of the admin interface. This is a pretty direct channel to me.

I also get paged when there are exceptions in shopify so I’m usually amongst the first to know. Unfortunatly the routing errors were thrown so far up the rails stack ( sorry for the tech talk ) that they weren’t cought by my exceptions loggers.

Might have to take a different route for logging exceptions in the future.

Tobias Lütke - Shopify CEO // http://twitter.com/tobi
0 Likes
Highlighted
New Member
3 0 0

How integration testing is being done for installing the shopify app 

and how unit testing is being performed in shopify through rails

0 Likes