Our Partner & Developer boards on the community are moving to a brand new home: the .dev community forums! While you can still access past discussions here, for all your future app and storefront building questions, head over to the new forums.

Shopify App fails the review if isTest false in the billing.require

Solved

Shopify App fails the review if isTest false in the billing.require

naji090
Shopify Partner
1 0 0

Hello, we created an embeded public app, the app is failing the review because of the billing api, the reviewer is using a test transaction to test the functionality, however in production mode billing.require doesn't return appSubscriptions that are test and so the app will ask you to subscribe again, not sure if i should keep isTest: true parameter untill the review is done and i switch to isTest: false after approval

 

The app was tested with isTest: true on the billing.require and works perfectly, but when isTest: false and submitted to review, The app fails to show the subscription, this is possibly because the reviewer is using a test transaction

 

How do apps submit the billing api for review (in test mode or live mode)?, if we omit isTest, it shows only live transactions and doesn't work either

 

The other option is to check for both test and live but doesn't seem correct

Accepted Solution (1)

jeff-edmondson
Shopify Partner
12 4 2

This is an accepted solution.

Hey! 

 

I just ran into this problem for my first app. 

 

I wrote a detailed blog post about it here: https://www.jeffedmondson.dev/shopify-billing/ but basically I set `isTest` to true while the app was in the review process and then once it was finally approved I set it back to `isTest: false`.


Additional Resource: https://github.com/Shopify/shopify-api-js/issues/882 

Fullstack Software Engineer empowering Shopify entrepreneurs
Apps: Redirect Ninja - Easy 404

View solution in original post

Reply 1 (1)

jeff-edmondson
Shopify Partner
12 4 2

This is an accepted solution.

Hey! 

 

I just ran into this problem for my first app. 

 

I wrote a detailed blog post about it here: https://www.jeffedmondson.dev/shopify-billing/ but basically I set `isTest` to true while the app was in the review process and then once it was finally approved I set it back to `isTest: false`.


Additional Resource: https://github.com/Shopify/shopify-api-js/issues/882 

Fullstack Software Engineer empowering Shopify entrepreneurs
Apps: Redirect Ninja - Easy 404