Development discussions around Shopify APIs
This is intended to be a followup of this closed topic https://ecommerce.shopify.com/c/shopify-apis-and-technology/t/recommended-library-for-multithreaded-...
@Peter, if you're still out there: It doesn't look like there's been any traction on the activeresource core PR https://github.com/rails/activeresource/pull/120 and I think at the moment those of us using the threadsafe version of the Shopify API are stuck on Rails 4.1. I know we can only do so much about the activeresource project, but any plans to update your threadsafe branch to track the latest release of activeresource so that rails can be updated to 4.2?
Thanks for any info!
@Justin,
Sorry for the late reply; I didn't see this until you linked it it from your github post.
Yes, I definitely plan to upgrade my threadsafe branch so it works with Rails 4.2. I'm still actively using it in multiple Rails 4.1 projects; I just haven't attempted to upgrade any of them to 4.2 yet so I haven't run into the issue myself.
If you get a chance, you could attempt to do the rebase yourself and open a pull request. Otherwise, I'll try to take a look sometime this month.
Cheers,
-Peter
Peter | Shopify
- Was my reply helpful? Click Like to let me know!
- Was your question answered? Mark it as an Accepted Solution
- To learn more visit the Shopify Help Center or the Shopify Blog
Sorry for the late reply; I didn't see this until you linked it it from your github post
No worries! I know there's no real user mentions over here like in github unfortunately, not to mention there's a lot of chatter always going on
Yes, I definitely plan to upgrade my threadsafe branch so it works with Rails 4.2. I'm still actively using it in multiple Rails 4.1 projects; I just haven't attempted to upgrade any of them to 4.2 yet so I haven't run into the issue myself.
Cool, makes sense
If you get a chance, you could attempt to do the rebase yourself and open a pull request. Otherwise, I'll try to take a look sometime this month.
Sure thing, I'll make an attempt at this today or tomorrow and report back. Thanks again as always!
Justin
I'm using the threadsafe branch without issues using Rails 4.2.
@Justin - we've updated our ActiveResource fork to work with Rails 4.2. Rather than tracking the branch (which was always a dubious thing for us to have recommended), you should now track the ActiveResource tag: https://github.com/Shopify/activeresource/releases/tag/4.2-threadsafe
Our plan, as long as this hasn't been merged upstream into ActiveResource, is to rebase a new tag on top of the latest ActiveResource upstream, whenever there's a major bump in Rails version.
Peter | Shopify
- Was my reply helpful? Click Like to let me know!
- Was your question answered? Mark it as an Accepted Solution
- To learn more visit the Shopify Help Center or the Shopify Blog
Hey Peter, thanks so much, I've been following the action on github, and I love the solution. Thanks to you and the rest of the guys for taking the time to get this together. Now if only ActiveResource would get their act together... ha ha
User | RANK |
---|---|
10 | |
4 | |
3 | |
3 | |
3 |
As a business owner, have you ever wondered when your customer's first impression of yo...
By Skye Jun 6, 2023We're excited to announce improvements to the threaded messaging experience in our communi...
By TyW May 31, 2023Thank you to everyone who participated in our AMA with Klaviyo. It was great to see so man...
By Jacqui May 30, 2023