Impact theme - slideshow video link

Impact theme - slideshow video link

AngeliqueV
Shopify Partner
3 0 2

Hello, I'm having a problem on the Shopify homepage of the Impact theme.

In my slideshow block, if I use a video block, for example, in the third position, the button link for that video block is then used for the button in the first position.

It seems the theme only allows for a video to appear on the first slide; otherwise, I have a problem with the link. Unfortunately, I need to have a video somewhere other than the first position.

How can I fix this problem, please?

Replies 3 (3)

Mastery
Tourist
7 0 1

It sounds like the Impact theme might not be properly handling button links when a video block is placed in a slide that isn't first. This could be due to how the theme assigns links dynamically in Liquid or JavaScript.

 

You may want to check how the slideshow’s code references button links—especially in slideshow.liquid and any related JavaScript files. Sometimes, themes are designed with assumptions about content order, and tweaking the way links are assigned could resolve the issue.

 

Have you looked into how the theme structures the slideshow data? That could be the key to fixing t

his.

Paul D
AngeliqueV
Shopify Partner
3 0 2

Hello Paul,
Thank you very much for your responsiveness. I'll try to look into it and get back to you.

AngeliqueV
Shopify Partner
3 0 2

I looked and there is :

{%- capture slide -%}
... tout le contenu de la slide ...
{%- endcapture -%}

{%- if block.settings.button_link != blank and block.settings.button_text == blank -%}
<a id="block-{{ block.id }}" href="{{ block.settings.button_link }}" class="slideshow__slide {% if forloop.first %}is-selected{% endif %}" data-slide-type="{{ block.type }}" role="group" {{ block.shopify_attributes }}>
{{- slide -}}
</a>
{%- else -%}
<div id="block-{{ block.id }}" class="slideshow__slide {% if forloop.first %}is-selected{% endif %}" data-slide-type="{{ block.type }}" role="group" {{ block.shopify_attributes }}>
{{- slide -}}
</div>
{%- endif -%}

 So I moved {%- capture slide -%} in front of each {{- slide -}}. But the bug persists.