Serious trouble converting our site features
Solved
I have put our testing code here so you can see what we are attempting to do. I know we really should be using product metadata in this use case rather than product attributes, but for now, ignore that as it has no effect on the functionality.
query RunInput {
cart {
lines {
id
quantity
quantity_price_breaks: attribute(key: "quantity_price_breaks"){
key
value
}
bundle_id: attribute(key: "bundle_id"){
key
value
}
bundle_products: attribute(key: "bundle_products"){
key
value
}
bundle_product_discount: attribute(key: "bundle_product_discount"){
key
value
}
merchandise{
... on ProductVariant {
id
product {
id
}
}
}
}
}
}
// -check
import { DiscountApplicationStrategy } from "../generated/api";
/**
* @typedef {import("../generated/api").RunInput} RunInput
* @typedef {import("../generated/api").FunctionRunResult} FunctionRunResult
*/
/**
* @type {FunctionRunResult}
*/
const EMPTY_DISCOUNT = {
discountApplicationStrategy: DiscountApplicationStrategy.First,
discounts: [],
};
/**
* {RunInput} input
* @returns {FunctionRunResult}
*/
export function run(input) {
const lines_length = input.cart.lines.length;
let count_of_products = {};
let variants_of_product = {};
let qty_price_breaks = {};
for(let i = 0; i < lines_length; i++){
if(input.cart.lines[i].bundle_products !== null && input.cart.lines[i].bundle_products.value.length > 0){
//is a bundle so ignore
} else {
if(typeof variants_of_product[input.cart.lines[i].merchandise.product.id] === 'undefined'){
variants_of_product[input.cart.lines[i].merchandise.product.id] = {};
}
variants_of_product[input.cart.lines[i].merchandise.product.id][input.cart.lines[i].merchandise.id] = true;
if(typeof count_of_products[input.cart.lines[i].merchandise.product.id] === 'undefined'){
count_of_products[input.cart.lines[i].merchandise.product.id] = 0;
}
count_of_products[input.cart.lines[i].merchandise.product.id] += input.cart.lines[i].quantity;
if(typeof qty_price_breaks[input.cart.lines[i].merchandise.product.id] === 'undefined' && input.cart.lines[i].quantity_price_breaks !== null && input.cart.lines[i].quantity_price_breaks.value.length > 0){
qty_price_breaks[input.cart.lines[i].merchandise.product.id] = input.cart.lines[i].quantity_price_breaks.value;
}
}
}
let discounts = [];
for(let i in count_of_products){
if(count_of_products.hasOwnProperty(i)){
if(typeof qty_price_breaks[i] !== 'undefined'){
const qty_bits = qty_price_breaks[i].split(";");
let discount = 0;
for(let j = 0; j < qty_bits.length; j++){
if(count_of_products[i] >= qty_bits[j].split(":")[0]){
discount = qty_bits[j].split(":")[1];
}
}
if(discount > 0){
let variants = [];
for(let k in variants_of_product[i]){
if(variants_of_product[i].hasOwnProperty(k)){
variants.push({
// Use the variant ID to create a discount target
productVariant: {
id: k
}
})
}
}
discounts.push({
// Apply the discount to the collected targets
targets: variants,
// Define a percentage-based discount
value: {
percentage: {
value: discount
}
}
})
}
}
}
}
if(discounts.length === 0){
return EMPTY_DISCOUNT;
} else {
return {
discounts: discounts,
discountApplicationStrategy: DiscountApplicationStrategy.First
};
}
};
For the following cart, it only applies the discount to one item, not all the ones we need.
So the main problem that we are having is enabling the discount to be applied to any line item, with any discount amount. Not to the first discount that matches.
