New GitHub Integration

[NegativeSpace]

While trying to setup the new github integration I ran into this error. The app is authorized in my github account but I keep getting this error

[sbstnslg]

same here 😕

[lewistyler]

+1

Looking forward to trying this out.

[NegativeSpace · Accepted solution]

@lewistyler @sbstnslg shopify updated the documentation to include this, it doesn't work if you go through the partner dashboard even on development stores. Create a staff account or login as the store owner and it will work!

[Benny7]

I had the same issue, but realized that I only had collaborator access on the store I was trying to add this to. Once added as a staff account, I was then able to access GitHub themes. Not sure if that is what is causing your issue, but might help others.

[sbstnslg]

Hmmm nope, does not work - I am the store owner, have forked the repo in my github account  and all permissions are granted.

[osiset]

This is simply not going to work for many agencies. Many are using connections through partner-collaborator account access.

Having a staff account won't work in the log run:

- Clients wont understand why theres a need

- Having clients create a staff account is tough

- Having a staff account simply to manage themes is not efficient... we'd have a partner-collaborator login and then a staff account

I was really excited for this feature, but given its gimped to staff accounts, this won't ever work and thats sad to see. 

[NegativeSpace]

@osiset I think it might only require a staff/owner account to setup the connection to the repo and then collaborator accounts can use it. I'm not 100% sure but I think that's how it works.

[Rockethouse]

Completely agree with @osiset.

Is there a plan to fix this in the near future? we're keen to switch our stores over to the Github integration asap but with the bizarre staff account limitation it's not possible, if the staff account issue can't be fixed can you guys consider giving an additional staff seat to plans (in particular the Basic plan who only get 2!) in the meantime so we can start using it?

It doesn't seem right to ask the store owner to free up one of their 2 staff accounts so their developer can use a Github integration.

Can we at least get some kind of explanation as to why Shopify have chosen to go down this route? 

[paulbraden]

It is not even working when I am using a staff account unless I am missing something. 

[mctenold]

For those not able to do this with a staff account either, try doing it in a private browser, or clearing all of your cookies. This worked for me and I was able to connect to Github.

[Arundas]

Beyond dumb. Many collaborators work on theme code. The GitHub integration is so weak, it's nearly useless.

• There's no true Git integration. We can't use BitBucket, GitLab or even self-hosted Git repositories.
• There's no way to connect an existing theme to a repository (or create a new repository from an existing theme).
• If disconnected, reconnecting is not allowed. Reconnecting should be allowed and conflicts reported.
• Commits created by Shopify are generic and confusing. Create an UI to give meaningful commit messages.
  • Example: when saving, a short description of what changed can be asked. It could also be automated by some form of basic AI.
• There's no way for collaborators to connect GitHub accounts. We need staff accounts. This defeats the purpose of having collaborator accounts.
• The account connection process is difficult. It's also not clear whether the same GitHub account can be connected to multiple Shopify stores.

Overall, yet another disappointing half-baked "feature" from Shopify.

[djcowan]

shopify updated the documentation to include this, it doesn't work if you go through the partner dashboard even on development stores. Create a staff account or login as the store owner and it will work!

A few complication arise given the following:

1. Collaborators can't create Staff accounts.
2. Store is owned by a third-party - logging into a store as the Owner would be a privilege violation.
3. All Staff Roles filled.