Newsletter pop-up keeps reappearing every time I change pages, even after I’ve closed it

[IvoireSkincare]

Hi, this is the code from my pop up and my theme.liquid if it helps!

{% if settings.newsletter_popup_image != blank %}

{% render 'rimg', img: settings.newsletter_popup_image, size: '1000x', lazy: true, crop: center, canvas: true %}

{% endif %}

{% if settings.newsletter_popup_title != blank %}

{{ settings.newsletter_popup_title }}

{% endif %}

{% if settings.newsletter_popup_text != blank %}

{{ settings.newsletter_popup_text }}

{% endif %}

{% if settings.newsletter_popup_form == true %}

{% render 'newsletter' %}

{% endif %}

{% if settings.newsletter_popup_link != blank and settings.newsletter_popup_link_text != blank %}

{{ settings.newsletter_popup_link_text }}

{% endif %}

and this is the code from my theme.liquid:

{% if current_tags %}{% assign meta_tags = current_tags | join: ', ’ %}{% endif %}

{% if template contains "index" %} {{ page_title }} {% else %} {{ page_title }} {% if current_tags %} {{ 'general.meta.tagged_html' | t: tags: meta_tags }}{% endif %} {% if current_page != 1 %} {{ 'general.meta.page' | t: page_number: current_page }}{% endif %} {% unless page_title contains shop.name %} - {{ shop.name }}{% endunless %} {% endif %}

{% if page_description %}

{% endif %}

{% render ‘social-meta-info’ %}

{% if collection.previous_product %}

{% endif %} {% if collection.next_product %} {% endif %}

{{ ‘theme.css’ | asset_url | stylesheet_tag }}

{% if settings.favicon != nil %}

{% else %} {% endif %}

{% if template contains ‘customer’ %}

{% endif %}

{% if settings.show_shipping_calculator %}

{% endif %}

{{ content_for_header }}

.collapsible-content { display: none; } .collapsible-description details summary { cursor: pointer; }

{% render 'age-gate', id: 'page', sections: content_for_layout %}

{{ ‘general.accessibility.skip_to_content’ | t }}

{% comment %}Icon star SVG{% endcomment %}

{% section ‘header’ %}

{{ content_for_layout }}

{% section ‘footer’ %}
{% if settings.newsletter_popup %}{% render ‘newsletter-popup’ %}{% endif %}
{% if settings.size_chart != blank and template contains ‘product’ %}{% render ‘size-chart-popup’ %}{% endif %}
{% render ‘modal’ %}
{% render ‘gallery-modal’ %}
{% render ‘predictive-search’ %}
{% if settings.cart_action == ‘ajax’ %}{% render ‘cart-drawer’ %}{% endif %}

[mageplaza-cs]

Hi @IvoireSkincare ,

I am from Mageplaza - Shopify solution expert.

Your JavaScript is targeting the wrong popup class, so the close state is never saved properly.

Specific issue:
In your JavaScript code (at the end of theme.liquid), you have:

const popup = document.querySelector('.popup-newsletter');
const closeBtn = popup?.querySelector('.close-popup');

But in your actual HTML for the popup, you wrote:

So:

- .popup-newsletter doesn’t exist -> popup is null
- As a result, the script does nothing, the popup is never hidden, and the closed state is never saved.

You just need to update the selectors to match the actual class names. Specifically, change this:

```javascript
const popup = document.querySelector('.newsletter-popup');
const closeBtn = popup?.querySelector('[data-popup-close]');

Updated working script:

Make sure you have CSS like .newsletter-popup.is-visible { display: block; } if you’re using classList.add.

Please let me know if it works as expected!

Best regards!