Shopify themes, liquid, logos, and UX
Hello, I am trying to replace <title> with <span> on the payment icons that are in the footer. See attached screenshot.
For some reason, I'm unable to locate where these payment icons are stored and can't seem to edit them. Any help would be appreciated! 🙂
Hello @dannanelli ,
Please refer below link
Hi there, thanks for trying to assist. The link you shared with me does not solve my problem. I am trying to find where the <title> can be changed to <span> on each payment icon.
Hello
I have a similar question regarding changing <title> to <span> relating to an issue I have found with the HTML generated by using Shopify Payments and the payment icons that are generated at the bottom of every page.
This is because Bing Webmaster SEO Analyser is telling me that the use of <title> more than once is not SEO friendly (in fact a "high severity SEO issue). I believe it should only be used to denote the page title in the head. So I'm not sure why Shopify Payments is set up to wrap every payment icon with the <title> tag.
See the warning message below:
I have not managed to locate where the payment icons are created, but I can see that they are called in to the footer.liquid via payment_type_svg_tag.
{% if section.settings.show_methods_of_payment %}
{% unless shop.enabled_payment_types == empty %}
<div class="grid">
<div class="grid__item text-center">
<span class="visually-hidden">{{ 'general.payment.method' | t }}</span>
<ul class="inline-list payment-icons">
{% for type in shop.enabled_payment_types %}
<li>
{{ type | payment_type_svg_tag: class: 'icon' }}
</li>
{% endfor %}
</ul>
</div>
</div>
{% endunless %}
{% endif %}
I have tried to perform a replace on this string, but I don't really think this is best practice. It also doesn't work when viewing the website - the icons all just disappear, which I am going down a rabbit hole trying to fix, as the code seems to not like anything other than <title>. Is there something special about the <title> that requires me to use it (it should only be used for the page title in the <head> as I understand it?
So ideally, my question is where is this variable set and can I there replace the <title> with <span> so that I am not marked down by Google for having multiple <title>s in my HTML
I am using the Minimise theme.
Many thanks!
Matthew
Hey Matthew,
did you ever find a solution to this issue?
Hello, @dannanelli
Thank you for your question.
Please share your store URL, page URL and also password (if your store has one), I'll help you out to the best of my ability.
They're very likely being injected via Javascript (perhaps with an app that you're using), therefore you wouldn't find it inside your theme.
Kind regards,
Diego
did anyone find a solution to this?
Hi there. try this, working with the actual dawn:
<script>
document.addEventListener("DOMContentLoaded", function() {
var paymentIcons = document.querySelectorAll(".list-payment__item svg");
paymentIcons.forEach(function(icon) {
var titleElement = icon.querySelector("title");
if (titleElement) {
var spanElement = document.createElement("span");
spanElement.innerHTML = titleElement.textContent;
icon.replaceChild(spanElement, titleElement);
}
});
});
</script>
<div class="footer__column footer__column--info">
{%- if section.settings.payment_enable -%}
<div class="footer__payment">
<span class="visually-hidden">{{ 'sections.footer.payment' | t }}</span>
<ul class="list list-payment" role="list">
{%- for type in shop.enabled_payment_types -%}
<li class="list-payment__item">
{{ type | payment_type_svg_tag: class: 'icon icon--full-color' }}
</li>
{%- endfor -%}
</ul>
</div>
{%- endif -%}
</div>
Is there any solution for DAWN?
Hi! use this code
just delete title
do not use span it will case error
contact me if you have questions
{%- for type in shop.enabled_payment_types -%}
{%- assign modified_type = type | payment_type_svg_tag: class: 'payment-icon' | replace: 'title', '' -%}
<li>{{ modified_type | replace: 'title', '' }}</li>
{%- endfor -%}
Hey Community! As the holiday season unfolds, we want to extend heartfelt thanks to a...
By JasonH Dec 6, 2024Dropshipping, a high-growth, $226 billion-dollar industry, remains a highly dynamic bus...
By JasonH Nov 27, 2024Hey Community! It’s time to share some appreciation and celebrate what we have accomplis...
By JasonH Nov 14, 2024