BUG: variant.incoming attribute returns true for variants in deleted transfers

[Baldur_Helgason]

So we’re using the variant.incoming attribute in our theme to display "Coming Soon" instead of "Sold Out" if there is incoming inventory.

However, we noticed when we created a transfer for some products but then deleted the transfer the variant.incoming is still "true" for those same products. Looking at the product in admin it shows Incoming: 0 so this must be some bug.

[Jur1]

Also, more or less related: If you copy a product that is a in a transfer (and so has incoming inventory), the variant.incoming is also copied into the new product. This new product has variant.incoming = true but you will not find in a transfer and you are not able to accept it unless you create and finish a new transfer. 

It took me hours to find out why I had products with incoming inventory while in fact there wasn't any incoming stock.

[Baldur_Helgason · Accepted solution]

For anyone running into this problem, here’s a solution:

Simply create a transfer including the production with the "phantom" incoming inventory, add some quantity to it, and finally delete the transfer. This will fix the variant.incoming value.

Here are the steps to reproduce this bug:

1. Create a transfer
2. Add two products, at least one of which is sold out
3. Put 1 as quantity (or any number)
4. Save
5. Change 1 to 0 on a sold out product, then immediately remove the product from the transfer
6. Save
7. Delete the transfer. Deleted product is still "incoming"

[kozzi]

Thank you for the workaround. I was just hitting this today!